feat: supported attach hint#833
Open
KirillKurdyukov wants to merge 7 commits into
Open
Conversation
KirillKurdyukov
force-pushed
the
feat-attach-stream
branch
from
397fc60 to
a94ba81
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (75.86%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
==========================================
- Coverage 81.01% 80.99% -0.02%
==========================================
Files 94 94
Lines 12091 12118 +27
Branches 1182 1190 +8
==========================================
+ Hits 9795 9815 +20
- Misses 1837 1842 +5
- Partials 459 461 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 63 out of 87 changed files in this pull request and generated 2 comments.
Files not reviewed (13)
- ydb/_grpc/v3/draft/protos/ydb_maintenance_pb2.py: Language not supported
- ydb/_grpc/v3/draft/protos/ydb_replication_pb2.py: Language not supported
- ydb/_grpc/v3/draft/protos/ydb_view_pb2.py: Language not supported
- ydb/_grpc/v3/draft/ydb_replication_v1_pb2.py: Language not supported
- ydb/_grpc/v3/draft/ydb_view_v1_pb2.py: Language not supported
- ydb/_grpc/v3/protos/ydb_query_pb2.py: Language not supported
- ydb/_grpc/v3/protos/ydb_topic_pb2.py: Language not supported
- ydb/_grpc/v3/ydb_table_v1_pb2.py: Language not supported
- ydb/_grpc/v4/draft/protos/ydb_maintenance_pb2.py: Language not supported
- ydb/_grpc/v4/draft/protos/ydb_replication_pb2.py: Language not supported
- ydb/_grpc/v4/draft/protos/ydb_view_pb2.py: Language not supported
- ydb/_grpc/v4/draft/ydb_replication_v1_pb2.py: Language not supported
- ydb/_grpc/v4/draft/ydb_view_v1_pb2.py: Language not supported
Comment on lines
+497
to
+504
| def _pessimize_node(self, node_id: Optional[int]) -> None: | ||
| """Deprioritize the connection attached to the given YDB node.""" | ||
| if node_id is None or node_id <= 0: | ||
| return | ||
|
|
||
| connection = self._store.connections_by_node_id.get(node_id) | ||
| if connection is not None: | ||
| self._on_disconnected(connection) |
Comment on lines
+147
to
+151
| self.DescribeExternalDataSource = channel.unary_unary( | ||
| '/Ydb.Table.V1.TableService/DescribeExternalDataSource', | ||
| request_serializer=protos_dot_ydb__table__pb2.DescribeExternalDataSourceRequest.SerializeToString, | ||
| response_deserializer=protos_dot_ydb__table__pb2.DescribeExternalDataSourceResponse.FromString, | ||
| _registered_method=True) |
🌋 SLO Test Results🟢 2 workload(s) tested — All thresholds passed
Generated by ydb-slo-action |
Co-authored-by: Cursor <cursoragent@cursor.com>
Move the missing-node-id check to the session and tighten the connection pool contract to accept a concrete int node id. Co-authored-by: Cursor <cursoragent@cursor.com>
Look up node connections under ConnectionsCache lock when pessimizing after NodeShutdown hints, and strip grpcio-tools version gates from v6 gRPC stubs so imports work with grpcio>=1.42.0. Co-authored-by: Cursor <cursoragent@cursor.com>
KirillKurdyukov
force-pushed
the
feat-attach-stream
branch
from
989b70e to
df4f0a4
Compare
Restore stubs from main and strip grpcio version gates via generate_protoc, instead of leaving broken conflict markers or truncated files. Co-authored-by: Cursor <cursoragent@cursor.com>
KirillKurdyukov
force-pushed
the
feat-attach-stream
branch
from
a0a70db to
3a583b1
Compare
Restore auto-generated stubs and generate_protoc.py to match main. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.